fix: prevent session destruction during possession/unpossession#21
fix: prevent session destruction during possession/unpossession#21insign wants to merge 1 commit into
Conversation
…mpersonation Removes `Session::invalidate()`, `Session::regenerateToken()`, and `Session::flush()` from `logoutAndDestroySession` in `PossessionManager`. These methods were aggressively destroying all application session state (like shopping carts) instead of just managing the authentication status. This ensures standard application states remain intact while using the impersonation feature. Co-authored-by: insign <1113045+insign@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
1 participant
Remove aggressive session flushing during
possessandunpossess.This PR removes
Session::invalidate(),Session::regenerateToken(), andSession::flush()fromlogoutAndDestroySessionbecause these methods unnecessarily wipe the entire session, destroying application states (such as shopping carts, checkout steps, or form data) when an admin impersonates or stops impersonating a user.By removing these, the original session integrity is preserved while safely logging out the previous guard context.
Includes new test cases in
tests/SessionFlushTest.phpto ensure unrelated session data is safely retained across the actions.PR created automatically by Jules for task 7268989724627422350 started by @insign